Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v*.sbt.json files in tests/test-data are built from regular MinHashes, not scaled MinHashes #1396

Closed
ctb opened this issue Mar 15, 2021 · 5 comments

Comments

@ctb
Copy link
Contributor

ctb commented Mar 15, 2021

This prohibits containment searches (which don't work correctly on regular MinHashes).

In particular, this affects test_sbt.py::test_tree_old_load(...), which uses search_minhashes_containment incorrectly.

It's not clear what the best option is here -

  • rebuild the test SBTs with scaled signatures?
  • remove support for old SBTs?
  • do something else?
@ctb
Copy link
Contributor Author

ctb commented Mar 15, 2021

  • SBTs v2 was in commit - 4fdd26c - looks like v2.0.0a2.
  • it's not clear that SBTs v1 were ever in a release by themselves? 16ec58a is what adds the SBT

@ctb
Copy link
Contributor Author

ctb commented Mar 15, 2021

v5 was never in a released version, either.

@ctb
Copy link
Contributor Author

ctb commented Mar 15, 2021

incidentally, this problem (the queries and SBTs being regular minhashes) makes it impossible to properly test the old SBTs. So that's the motivation for fixing it!

@ctb
Copy link
Contributor Author

ctb commented Mar 16, 2021

note also that v1.sbt.json doesn't support leaf iteration via .leaves() which in turn means it doesn't support Index.signatures().

@ctb
Copy link
Contributor Author

ctb commented Apr 23, 2021

in #1392 we disabled v1 and v2 tests, FBFW.

@ctb ctb closed this as completed Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant