Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write command-line test for lca summarize --query-from-file #1451

Open
ctb opened this issue Apr 11, 2021 · 0 comments
Open

write command-line test for lca summarize --query-from-file #1451

ctb opened this issue Apr 11, 2021 · 0 comments
Labels
good first issue python Pull requests that update Python code testing

Comments

@ctb
Copy link
Contributor

ctb commented Apr 11, 2021

per https://github.com/dib-lab/sourmash/pull/1423/files#r604406992 as well as attached screenshot, we do not currently test sourmash lca summarize --query-from-file
Screen Shot 2021-04-11 at 10 57 06 AM

To address this issue:

  • make a copy of test_single_summarize() in tests/test_lca.py and name it something like test_single_summarize_query_from_file();
  • modify the new test to create a text file containing the path to input_sig
  • modify the utils.runscript(...) command to remove --query and instead pass in --query-from-file with the new text file
@ctb ctb added good first issue python Pull requests that update Python code testing labels Apr 11, 2021
@bryshalm bryshalm assigned bryshalm and unassigned bryshalm May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue python Pull requests that update Python code testing
Projects
None yet
Development

No branches or pull requests

2 participants