Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we change sourmash sig describe to use manifests? #1846

Open
ctb opened this issue Feb 17, 2022 · 2 comments
Open

can we change sourmash sig describe to use manifests? #1846

ctb opened this issue Feb 17, 2022 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Feb 17, 2022

looking at the code, probably, yes! #1837 would help with this.

background and motivation: for large .sig.gz files, it is annoying to load all of the JSON if you just want specific moltypes/ksizes/etc. so in various places I have been building .zip files instead so we can just load the one signature we want based on manifests.

but then it occurred to me that for things like describe, we have most (all?) of the information present in the manifest.

so this would be much faster for databases with manifests!

@ctb
Copy link
Contributor Author

ctb commented Feb 19, 2022

alas, no, we cannot - manifests do not contain seed or license information!

If and when we upgrade or refactor manifest content, these will be something to add, I think.

@ctb
Copy link
Contributor Author

ctb commented Mar 12, 2022

adding sum_hashes in #1882, which is also not present in manifests.

on the flip side, I also added --include-db-pattern and --exclude-db-pattern to sig describe in #1882, which I think makes it less important to use manifests for things - sig describe is mostly intended to be for humans, who wouldn't want to look at all the output for gazillions of signatures anyway.

@ctb ctb changed the title can we change sourmash sig describe to use manifests?? can we change sourmash sig describe to use manifests? Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant