MRG: upgrade sig overlap and sig subtract to load more than JSON signatures
#3153
+127
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3153 +/- ##
==========================================
+ Coverage 86.66% 86.67% +0.01%
==========================================
Files 136 136
Lines 15814 15828 +14
Branches 2713 2713
==========================================
+ Hits 13705 13719 +14
Misses 1799 1799
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
ctb
changed the title
sig overlap and sig subtractsig overlap and sig subtract
|
Ready for review @sourmash-bio/devs |
5 tasks
ctb
changed the title
sig overlap and sig subtractsig overlap and sig subtract to load more than JSON signatures
|
@ccbaumler @AnneliektH would either of you be able to look at this and (potentially) approve it? lmk if you don't have review privileges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
sig overlapandsig subtractto take more than just JSON signatures.Also, adds a function
sourmash_args.load_one_signaturethat I think should (eventually) replace the now-deprecatedsourmash.signature.load_one_signature. This will be the topic of a new PR - for now, I think it's a nice quick fix!Fixes #3136
Related issues:
load_one_signatureuseload_file_as_signaturesAPI #1062 - will do another PR to close this issueload_*sig/db functions insourmash_args.py#1877TODO: