Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rust version check and install link to readme #33

Closed
wants to merge 1 commit into from

Conversation

ccbaumler
Copy link

fixes #32

I was cleaning up my account a few days back and deleted cargo without thinking about it. I got this error and realized my mistake. After reinstalling rust everything is running again!
I think you may want to add the link to install rust in your install instructions!

$ pip install sourmash_plugin_directsketch==0.3.0

Collecting sourmash_plugin_directsketch==0.3.0
  Using cached sourmash_plugin_directsketch-0.3.0.tar.gz (152 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      error: rustup could not choose a version of cargo to run, because one wasn't specified explicitly, and no default is configured.
      help: run 'rustup default stable' to download the latest stable release of Rust and set it as your default toolchain.

      Cargo, the Rust package manager, is not installed or is not on PATH.
      This package requires Rust and Cargo to compile extensions. Install it through
      the system's package manager or via https://rustup.rs/

      Checking for Rust toolchain....
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

@bluegenes
Copy link
Collaborator

bluegenes commented May 21, 2024

Thanks for the PR! Thinking on it -- I'd like to avoid having folks install rust directly. But that means I should actually describe the install process from conda using environment.yml file in the README.

I'm not sure how this interacts with existing cargo on your system - would assume if you already had rust it would not reinstall via conda. Which is maybe why deleting cargo borked everything?

Let's keep this open for now and I'll do some testing!

@bluegenes
Copy link
Collaborator

or better yet, I should go ahead and make this conda installable

@ccbaumler
Copy link
Author

That sounds like a much nicer solution!

@bluegenes
Copy link
Collaborator

@ccbaumler can I close this? Aka, did the conda installation solve this for you?

@ccbaumler
Copy link
Author

Sounds good to me. I believe that my issue has been solved.

@bluegenes bluegenes closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rust install to README's install section
2 participants