Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables enhancements #10

Merged
merged 1 commit into from Dec 12, 2012
Merged

iptables enhancements #10

merged 1 commit into from Dec 12, 2012

Conversation

tjoneseng
Copy link
Contributor

  1. generate rules for all listen ports
  2. add recipe to generate rules

1. generate rules for all listen ports
2. add recipe to generate rules
@miketheman
Copy link
Contributor

@tjoneseng This introduces a dependency on the iptables cookbook which is not reflected in the cookbook's metadata.rb.

@miketheman
Copy link
Contributor

Also, is there an associated JIRA ticket? You may wish to review http://wiki.opscode.com/display/chef/How+to+Contribute

@tjoneseng
Copy link
Contributor Author

@miketheman,

The dependency on iptables is optional, and existed before this patch (note the existing template port_apache.erb). The new rule I added is only useful if the user already has iptables installed (i.e., the user is not going to need an iptables rule for apache2 unless they've already got iptables set up). My intent was not to make iptables a required dependency, as not all users will want to use it.

I filed COOK-1456 in JIRA for this pull request.

On Jul 14, 2012, at 5:13 AM, Mike Fiedler wrote:

@tjoneseng This introduces a dependency on the iptables cookbook which is not reflected in the cookbook's metadata.rb.


Reply to this email directly or view it on GitHub:
#10 (comment)

@miketheman
Copy link
Contributor

I transitioned the ticket to "Fix Provided" to raise its visibility.

# Cookbook Name:: apache2
# Recipe:: iptables
#
# Copyright 2008-2009, Opscode, Inc.

This comment was marked as outdated.

This comment was marked as outdated.

jtimberman pushed a commit that referenced this pull request Dec 12, 2012
@jtimberman jtimberman merged commit a515ebf into sous-chefs:master Dec 12, 2012
rtkghesselink added a commit to rtkwlf/apache2 that referenced this pull request Jan 9, 2014
Report the differences between two distributions' snapshots
 - This can be ran through Jenkins to report this data automatically
Reviewed by: Peter
[https://trello.com/c/eDHYqLjM]
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants