iptables enhancements #10

Merged
merged 1 commit into from Dec 12, 2012

Conversation

Projects
None yet
4 participants
@tjoneseng
Contributor

tjoneseng commented Jul 6, 2012

  1. generate rules for all listen ports
  2. add recipe to generate rules
iptables enhancements
1. generate rules for all listen ports
2. add recipe to generate rules
@miketheman

This comment has been minimized.

Show comment Hide comment
@miketheman

miketheman Jul 14, 2012

Contributor

@tjoneseng This introduces a dependency on the iptables cookbook which is not reflected in the cookbook's metadata.rb.

Contributor

miketheman commented Jul 14, 2012

@tjoneseng This introduces a dependency on the iptables cookbook which is not reflected in the cookbook's metadata.rb.

@miketheman

This comment has been minimized.

Show comment Hide comment
@miketheman

miketheman Jul 14, 2012

Contributor

Also, is there an associated JIRA ticket? You may wish to review http://wiki.opscode.com/display/chef/How+to+Contribute

Contributor

miketheman commented Jul 14, 2012

Also, is there an associated JIRA ticket? You may wish to review http://wiki.opscode.com/display/chef/How+to+Contribute

@tjoneseng

This comment has been minimized.

Show comment Hide comment
@tjoneseng

tjoneseng Jul 14, 2012

Contributor

@miketheman,

The dependency on iptables is optional, and existed before this patch (note the existing template port_apache.erb). The new rule I added is only useful if the user already has iptables installed (i.e., the user is not going to need an iptables rule for apache2 unless they've already got iptables set up). My intent was not to make iptables a required dependency, as not all users will want to use it.

I filed COOK-1456 in JIRA for this pull request.

On Jul 14, 2012, at 5:13 AM, Mike Fiedler wrote:

@tjoneseng This introduces a dependency on the iptables cookbook which is not reflected in the cookbook's metadata.rb.


Reply to this email directly or view it on GitHub:
opscode-cookbooks#10 (comment)

Contributor

tjoneseng commented Jul 14, 2012

@miketheman,

The dependency on iptables is optional, and existed before this patch (note the existing template port_apache.erb). The new rule I added is only useful if the user already has iptables installed (i.e., the user is not going to need an iptables rule for apache2 unless they've already got iptables set up). My intent was not to make iptables a required dependency, as not all users will want to use it.

I filed COOK-1456 in JIRA for this pull request.

On Jul 14, 2012, at 5:13 AM, Mike Fiedler wrote:

@tjoneseng This introduces a dependency on the iptables cookbook which is not reflected in the cookbook's metadata.rb.


Reply to this email directly or view it on GitHub:
opscode-cookbooks#10 (comment)

@miketheman

This comment has been minimized.

Show comment Hide comment
@miketheman

miketheman Dec 10, 2012

Contributor

I transitioned the ticket to "Fix Provided" to raise its visibility.

Contributor

miketheman commented Dec 10, 2012

I transitioned the ticket to "Fix Provided" to raise its visibility.

+# Cookbook Name:: apache2
+# Recipe:: iptables
+#
+# Copyright 2008-2009, Opscode, Inc.

This comment has been minimized.

Show comment Hide comment
@btm

btm Dec 12, 2012

Contributor

It's best to be correct when setting Copyrights.

@btm

btm Dec 12, 2012

Contributor

It's best to be correct when setting Copyrights.

This comment has been minimized.

Show comment Hide comment
@jtimberman

jtimberman Dec 12, 2012

Member

Fixed post merge: a920e04

@jtimberman

jtimberman Dec 12, 2012

Member

Fixed post merge: a920e04

jtimberman added a commit that referenced this pull request Dec 12, 2012

@jtimberman jtimberman merged commit a515ebf into sous-chefs:master Dec 12, 2012

rtkghesselink added a commit to rtkwlf/apache2 that referenced this pull request Jan 9, 2014

Merge pull request #10 from rtkghesselink/repos
Report the differences between two distributions' snapshots
 - This can be ran through Jenkins to report this data automatically
Reviewed by: Peter
[https://trello.com/c/eDHYqLjM]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment