COOK-4534: Add option to update apt cache at compiletime #75
Conversation
| @@ -23,6 +23,7 @@ | |||
| default['apt']['cacher_port'] = 3142 | |||
| default['apt']['caching_server'] = false | |||
| default['apt']['compiletime'] = false | |||
| default['apt']['compile_time_update'] = false | |||
There was a problem hiding this comment.
I'm not sure we need another attribute for this. I would just use the existing compiletime attribute.
There was a problem hiding this comment.
My only reason for making a new attribute is that I am unsure if current users of the compiletime attribute want it to also update the cache. The functionality of the apt cookbook's compiletime attribute is pretty specific and not necessarily part of what people want/need for running updates at compile time. As I discussed in my PR, I think this probably needs to be addressed by a larger refactor. This implementation adds the desired functionality without breaking anything for current users.
There was a problem hiding this comment.
It does seem in retrospect that it was a mistake to not have compiletime be more specific, e.g. cacher_compile_time + update_compile_time.
There have been lots of times I've done testing in EC2 on older instances and have had failures on bootstrap because the apt cache was out of date and pointed to old versions of a package. I would have wanted a compile time update, but the cacher business would have been unnecessary (or potentially a problem?).
I'm not in love with more attributes, but I don't see another way to do this.
|
Corresponding Chef ticket: https://tickets.opscode.com/browse/COOK-4534 |
btm
changed the title
|
merged in fa34970 |
https://tickets.opscode.com/browse/COOK-4534
This pull-request adds a
compile_time_updateattribute to the Apt cookbook to force anapt-get updateat compile time in order to ensure cookbooks that have an option to run at compile time can install packages. I usedcompile_time_updatebecausecompiletimeis already being used for a different functionality. However, in the future, it may be useful to refactor these into attributes that are more obvious.History
Changes in the build-essential cookbook (discussed here) have removed build-essential's behavior of running
apt-get updatebefore attempting to install packages when invoked at compile time. Per the linked discussion in the build-essential cookbook, @sethvargo recommended updating the Apt cookbook to provide an option to run at compile time instead of build-essential being responsible for it.