Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using Encrypted EBS volume with the ebs_raid provider #165

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

DrMerlin
Copy link

See Issue #164

This has the proper passthrough for EBS Volumes to be created with encryption when created through the EBS_Raid resource.

History:

PR #114 brought in the ability to create Encrypted EBS volumes, however it didn't provide a passthrough for volumes created as part of a raid to be created with encryption.

I wrote PR #130 to fix this right after PR #114 was merged, but it included a general fix for EBS Raids that was sliced out into its own PR #156, which was recently merged. So I am submitting a new PR with just the remaining Encryption fix for volumes created in a Raid.

@DrMerlin
Copy link
Author

FYI @miketheman and @scalp42

@scalp42
Copy link
Contributor

scalp42 commented Sep 2, 2015

@miketheman or @tas50 can we get this merged? These were missing and just pass through.

@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

@DrMerlin
Copy link
Author

Hmm... I signed the CLA when I worked for my previous company and opened this PR. I have since started work for another company- so I signed the ICLA again. Hopefully that works.

@DrMerlin
Copy link
Author

@miketheman I signed the ICLA and it doesn't seem to have added the Signed CLA tag for me. Do I also need the CCLA? I no longer work for a company with a signed CCLA, but I did when I opened this PR.

@miketheman
Copy link
Contributor

I'm not certain how currybot works - maybe @cwebberOps or @nellshamrell can shed some light?

@scalp42
Copy link
Contributor

scalp42 commented Nov 4, 2015

It's been months and this is a very straightforward PR. Anything I could do to speed up the process?

cc @DrMerlin @tas50 @miketheman

@DrMerlin
Copy link
Author

DrMerlin commented Nov 5, 2015

Hey @scalp42, thanks for keeping tabs on this PR. As I'm sure you've read, I guess I'm in CLA limbo. I signed the ICLA, and can't sign the CCLA. Everything was signed for several months (especially considering the previous version of this PR), until I changed companies. But now it says Unsigned, despite my several attempts to sign and re-sign the ICLA.

@tas50
Copy link
Contributor

tas50 commented Nov 25, 2015

Seems super straight forward.

tas50 added a commit that referenced this pull request Nov 25, 2015
EBSEncryptedRaid fixes to AWS cookbook 2.7.2 (Issue #164)
@tas50 tas50 merged commit 7fdf3b9 into sous-chefs:master Nov 25, 2015
@DrMerlin
Copy link
Author

Bless you!

Thanks @scalp42

FYI @dthornton

@tas50 tas50 changed the title EBSEncryptedRaid fixes to AWS cookbook 2.7.2 (Issue #164) Fix using Encrypted EBS volume with the ebs_raid provider Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants