Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #58 - convert splunk_installer to a real resource #119

Merged
merged 6 commits into from
Oct 2, 2019
Merged

Fixed issue #58 - convert splunk_installer to a real resource #119

merged 6 commits into from
Oct 2, 2019

Conversation

haidangwa
Copy link
Contributor

@haidangwa haidangwa commented Jun 6, 2019

  • Fixed issue #58 Converted the splunk_installer definition into a custom resource
  • Fixed issue #101 Added sensitive true to the execute resource
  • Fixed issue #118 removed omnios platform tests
  • bumped chef-vault dependency to ~> 3.1.1
  • moved content from files/default and templates/default in accordance with modern file specificity rules
  • require Chef 13.11 or newer
  • Removed (undocumented) support for Solaris (OmniOS) platform; omnios is not a platform
    that can currently be tested under ChefSpec and Test Kitchen.
  • fixes to ensure splunk run as a non-root user
  • added helper methods: #splunk_runas_user and #splunk_service_provider
  • Fixed logic in setup_shcluster recipe and fixed the corresponding chefspec
  • added sensitive true for SSL certificate private key and certificate resources
  • ensured yum-centos repository is enabled in Test Kitchen for tests requiring centos or redhat

Description

This converts the splunk_installer definition to a custom resource, updates test kitchen and chefspec tests (all pass now), and splunk can now run as non-root user.

Issues Resolved

#58
#101
#118

Check List

kitchen.yml Outdated Show resolved Hide resolved
libraries/matchers.rb Outdated Show resolved Hide resolved
metadata.rb Outdated Show resolved Hide resolved
metadata.rb Outdated Show resolved Hide resolved
resources/splunk_installer.rb Outdated Show resolved Hide resolved
resources/splunk_installer.rb Outdated Show resolved Hide resolved
@tas50
Copy link
Contributor

tas50 commented Oct 1, 2019

@haidangwa Thanks for taking this on. It's going to be nice to have a real resource here.

…to a custom resource

- Fixed issue [#101](#101) Added sensitive true to the execute resources with commands containing splunk auth
- Fixed issue [#118](#118) removed omnios platform tests
- bumped chef-vault dependency to `>= 3.1.1`
- moved content from files/default and templates/default in accordance with modern file specificity rules require Chef 13.11 or newer
- Removed (undocumented) support for Solaris (OmniOS) platform; omnios is not a platform that can currently be tested under ChefSpec and Test Kitchen.
- fixes to ensure splunk run as a non-root user
- added helper methods: `#splunk_runas_user` and `#splunk_service_provider`
- Fixed logic in setup_shcluster recipe and fixed the corresponding chefspec
- added `sensitive true` for SSL certificate private key and certificate resources
- ensured yum-centos repository is enabled in Test Kitchen for tests requiring centos or redhat

Signed-off-by: Dang H. Nguyen <dang.nguyen@disney.com>
Signed-off-by: Dang H. Nguyen <dang.nguyen@disney.com>
…ame way as the 'chef-splunk::service' recipe

Signed-off-by: Dang H. Nguyen <dang.nguyen@disney.com>
Signed-off-by: Dang H. Nguyen <dang.nguyen@disney.com>
…nt_spec.rb

Signed-off-by: Dang H. Nguyen <dang.nguyen@disney.com>
…orce modern file specificity

Signed-off-by: Dang H. Nguyen <dang.nguyen@disney.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants