Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart followed by reload is unnecessary #438

Closed
moofish32 opened this issue May 21, 2017 · 3 comments
Closed

restart followed by reload is unnecessary #438

moofish32 opened this issue May 21, 2017 · 3 comments
Assignees
Milestone

Comments

@moofish32
Copy link

The default recipe currently sets up a situation in which restart is called followed immediately by reload. Is there a benefit here? The disadvantage is that in RHEL 6.9 consul actually fails to start because these are called back to back for me. I would say it's definitely a race condition but seems to be about 8 out of 10 so far.

If we make this a restart, then only one action is taken and I think everything works.
https://github.com/johnbellone/consul-cookbook/blob/master/recipes/default.rb#L21

@legal90
Copy link
Contributor

legal90 commented May 27, 2017

@moofish32 Thank you for pointing on this! You're right - we actually have two subsequent actions with Consul service on the initial bootstrap:

       Recipe: consul::default
         * consul_service[consul] action restart
           * poise_service[consul] action restart
             * service[consul] action restart
        - restart service service[consul]


         * consul_service[consul] action reload
           * poise_service[consul] action reload
             * service[consul] action reload
        - reload service service[consul]

And that should be fixed. I'll look into it soon.

@legal90
Copy link
Contributor

legal90 commented May 27, 2017

Fixed by #443

@legal90 legal90 closed this as completed May 27, 2017
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants