Remove the notification for consul service restart #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to notify consul service by changes of `poise_service_user` resource: - It is useless for initial converge because the service will start automatically after and it happens _after_ user creation. - We should not restart the service automatically even if the name of service user has been changed for an existing installation. In this case the restart is harmful, because consul data (/var/lib/consul/*) is still owned by an old user, so it should be handled by a special order: 1) stop service, 2) change data files ownership, 3) start service. So, it's out of this cookbook's scope.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue #438
We don't need to notify consul service by changes of
poise_service_userresource:It is useless for initial converge because the service will start automatically after and
it happens after user creation.
We should not restart the service automatically even if the name of service user has been
changed for an existing installation. In this case the restart is harmful, because consul data
(/var/lib/consul/*) is still owned by an old user, so it should be handled by a special procedure: 1)stop service, 2)change data files ownership, 3)start service.
So, it's out of this cookbook's scope.