Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should check_def create the file using the id property instead of name? #99

Closed
tgwizard opened this issue Dec 11, 2014 · 2 comments · Fixed by #100
Closed

Should check_def create the file using the id property instead of name? #99

tgwizard opened this issue Dec 11, 2014 · 2 comments · Fixed by #100

Comments

@tgwizard
Copy link
Contributor

https://github.com/johnbellone/consul-cookbook/blob/master/resources/check_def.rb#L31

I think that names usually/often contain spaces, as they do in the examples here https://consul.io/docs/agent/checks.html and in "Serf Health Status". Wouldn't it be better to use id - "serfHealth" - as part of the name of the file instead?
@johnbellone
Copy link
Contributor

@tgwizard I don't have a problem with this change. Do you want to submit a PR?

@tgwizard tgwizard mentioned this issue Dec 12, 2014
Merged
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer id over name consul check filename
2 participants
@johnbellone @tgwizard