Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add statsd support #114

Merged
merged 1 commit into from
Mar 14, 2015
Merged

Conversation

akerekes
Copy link
Contributor

@akerekes akerekes commented Feb 2, 2015

These changes were introduced by #91 (among others). I've split that PR into smaller chunks in hope for easier merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e728e82 on akerekes:support_statsd into e332fc9 on johnbellone:master.

@akerekes
Copy link
Contributor Author

akerekes commented Feb 2, 2015

I'm trying to run the rspec tests, but I get the following

consul-cookbook/spec/spec_helper.rb:2:in `require': cannot load such file -- chefspec/berkshelf (LoadError)
from /home/adminuser/akerekes_checkout/consul-cookbook/spec/spec_helper.rb:2:in `<top (required)>'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1072:in `require'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1072:in `block in requires='
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1072:in `each'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1072:in `requires='
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration_options.rb:103:in `block in process_options_into'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration_options.rb:102:in `each'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration_options.rb:102:in `process_options_into'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration_options.rb:22:in `configure'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:95:in `setup'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:84:in `run'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:69:in `run'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:37:in `invoke'
from /var/lib/gems/1.9.1/gems/rspec-core-3.1.7/exe/rspec:4:in `<top (required)>'
from bin/rspec:16:in `load'
from bin/rspec:16:in `<main>'

Any ideas how to fix this?

@akerekes
Copy link
Contributor Author

I've rebased this pull request too in hope that it will be merged sooner.

@akerekes
Copy link
Contributor Author

@johnbellone do you have an estimate when can this PR be merged? Thanks!

@adgaudio adgaudio mentioned this pull request Mar 4, 2015
@adgaudio
Copy link

adgaudio commented Mar 4, 2015

+1 would be really great to merge this so we can hook consul up with our statsd server!

johnbellone added a commit that referenced this pull request Mar 14, 2015
@johnbellone johnbellone merged commit 1bba043 into sous-chefs:master Mar 14, 2015
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants