Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #116 by replacing :touch with :create action #117

Closed
wants to merge 3 commits into from

Conversation

akerekes
Copy link
Contributor

@akerekes akerekes commented Feb 2, 2015

These changes were introduced by #91 (among others). I've split that PR into smaller chunks in hope for easier merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c50edac on akerekes:fix_for_116 into e332fc9 on johnbellone:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f7fc1b7 on akerekes:fix_for_116 into e332fc9 on johnbellone:master.

@tgwizard
Copy link
Contributor

tgwizard commented Feb 4, 2015

Really 👍 for this! The failing tests seem to be a common problem of all PRs of late, ChefSpec::Error::CommandNotStubbed:, not a problem with this specific change.

@johnbellone
Copy link
Contributor

I can take a look into the failed tests separately.

Can we remove the action statement since the file resource uses create by default? It's pretty confusing looking at it with the guard in there.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1923a69 on akerekes:fix_for_116 into e332fc9 on johnbellone:master.

@johnbellone
Copy link
Contributor

Please rebase!

@johnbellone johnbellone added the bug label Feb 9, 2015
@johnbellone johnbellone added this to the Road to 1.0.0 milestone Feb 9, 2015
@akerekes
Copy link
Contributor Author

#116 has been fixed by #121, so I think this pull request can be closed.

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants