Set GOMAXPROCS > 1 #118
Closed
Set GOMAXPROCS > 1 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make local environments more isolated.
| @@ -0,0 +1 @@ | |||
| consul-cookbook | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Please rebase! |
johnbellone
added a commit
that referenced
this pull request
Feb 13, 2015
johnbellone
added a commit
that referenced
this pull request
Mar 14, 2015
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This it should be, according to https://groups.google.com/forum/#!topic/consul-tool/qewFEqgAoF8. This PR still makes it possible to set it to one, just changes the default to
max(node['cpu']['total'], 2).One issue with this change though is that the consul service isn't restarted when the change has been applied to
/etc/default/consul. A:restartnotification could be added for that resource, but then the service would also be restarted once on the initial install. I'm not sure how this should be solved, and if.