remove unit tests which describe exactly what the code describes #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset
added a commit
that referenced
this pull request
Feb 6, 2015
remove unit tests which describe exactly what the code describes
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnbellone not sure who had written these, but I've seen a lot of this since test-kitchen started picking up speed. It doesn't help that the very first example of test-kitchen (back at the 2nd annual community summit) was for installing a Redis instance using one of these types of tests. We need to advocate for functional tests for recipes and not unit tests. They are absolutely and completely useless.
Unit tests for recipes are just code duplication which makes things more difficult to maintain while completely missing the point of testing functionality. Recipes aren't a unit of code, they are a set of instructions which build a feature. They can only be properly tested by a functional test. We should avoid merging these types of tests into our codebase.
The LWRP unit tests are marginally useful so I've left them. They could just as easily be tested by a functional test as well (and they should).