Feature/windows support

[calvn]

Fixed feature/windows_support to be on a working state against master in addition to some chocolatey tweaks.

A lot of credit to @ramarnat for the initial #119 PR

[coveralls]

Coverage remained the same at 100.0% when pulling 40531ae on cleung2010:feature/windows_support into 76f7831 on johnbellone:master.

[ramarnat]

nice!

[johnbellone]

@cleung2010 Is this ready to merge?

[calvn]

Yep!

[ghost]

even though consul metadata has depend 'chcocolatey', my chef run fails as below
uninitialized constant Chef::Node::ChocolateyHelpers

Looks like it can not find the resource ChocolateyHelpers defined in the libraries on chocolatey cookbook

[ghost]

It was because of my chef version upgraded from 11.6.2 to 11.18.6 and the problem went away.

Also I used #{ENV.keys.grep(/^ChocolateyInstall$/i)} instead of calling the helper function in 11.6 and that solved the problem

Tested the install_windows recipe and it works the only problems were chocolatey ones due to chef version, 11.18.6 worked without a problem

[johnbellone]

Please rebase!

[calvn]

@johnbellone I fixed conflicts with master, should be good to merge now

[johnbellone]

We are going to be merging #126 soon. Please take a look at that as it changes the installation for clients.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.