Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for runit #16

Merged
merged 3 commits into from Jun 11, 2014

Conversation

Projects
None yet
2 participants
@webcoyote
Copy link
Contributor

commented Jun 6, 2014

Since /etc/init.d doesn't handle application crashes gracefully by restarting the consul application, I've updated the service recipe to >optionally< use runit (controlled by node[:consul][:init_style] since runit does handle application crashes. I've configured the default init_style to 'init' so that any current users of the cookbook won't be surprised by this addition.

Runit can also change the user/group of the consul application so it doesn't have to run as root. If the user selects runit init_style I update the /etc/consul.d, /var/log/consul and /var/lib/consul directories to be owned by that user/group instead of root/root.

Let me know if you'd like any additional changes to accept this pull request. I've tested my changes, and am running this in a development environment, where it's working perfectly.

Thanks for creating this cookbook, by the way!

@webcoyote

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2014

Rebased on top of master; now takes configuration from default.json file.

@johnbellone

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2014

That's all comments I have! Great work!

@webcoyote

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2014

I've made the three updates you suggested; thanks for the feedback.

johnbellone added a commit that referenced this pull request Jun 11, 2014

@johnbellone johnbellone merged commit 1718eb3 into sous-chefs:master Jun 11, 2014

@webcoyote webcoyote deleted the webcoyote:consul-runit branch Jun 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.