Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor start and stop timeouts in consul-init #161

Merged
merged 1 commit into from Jun 16, 2015

Conversation

Projects
None yet
4 participants
@jon918
Copy link
Contributor

jon918 commented Apr 6, 2015

Based on the mysql-server init script.

I found that the 10 second timeout on shutdown wasn't enough, I was getting some errors that were resolved by increasing to 30.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 6, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 4f6bf5f on localytics:centos_initd_script into 8670b01 on johnbellone:master.

Refactor start and stop timeouts in consul-init
Based on the mysql-server init script

@jon918 jon918 force-pushed the localytics:centos_initd_script branch from 4f6bf5f to 459312d Apr 6, 2015

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 6, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 459312d on localytics:centos_initd_script into 8670b01 on johnbellone:master.

@mjuszczak

This comment has been minimized.

Copy link

mjuszczak commented Apr 8, 2015

👍

@johnbellone johnbellone added the review label May 1, 2015

johnbellone added a commit that referenced this pull request Jun 16, 2015

Merge pull request #161 from localytics/centos_initd_script
Refactor start and stop timeouts in consul-init

@johnbellone johnbellone merged commit babe38d into sous-chefs:master Jun 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.