use node array to refer to variables #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Square-brackets notation and dot notation for attributes is a stylistic choice and should behave mostly identically in either case. If you're seeing otherwise, that sounds like a bug. It's been some months since I wrote that code, but I actually do prefer square-brackets notation in my personal work. Odds are I was matching other code in this cookbook due to a FoodCritic rule or something of that nature - I can't think of why else I would write it this way. |
jedineeper
force-pushed
the
b-atlas-params-not-picked-up
branch
from
5ac28c7
to
65bc614
Compare
|
rebased on master 5 July 2015. |
johnbellone
added a commit
that referenced
this pull request
Jul 6, 2015
use node array to refer to variables
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this cookbook via the "include_recipe 'consul'" method as I include this in one of my "base-server" cookbooks.
When I try to pass atlas autojoin/cluster/token variables through my cookbook the variables are not picked up by consul. I had a look through the code and found that the variables were referenced via "node.consul.atlas_autojoin" rather than "node['consul']['atlas_autojoin']". I'm not sure if there was a particular reason for this but changing it like this means the variables are picked up correctly.
@shanesveller originally wrote this in #135 not sure if there was a reason you referenced the variables this way Shane so happy for commentary if there was a particular reason :)
Tests still pass correctly, though I'm not sure how to word a test to cover this particular case?
Thanks,
Craig