Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows data path #275

Merged
merged 2 commits into from Feb 8, 2016
Merged

Windows data path #275

merged 2 commits into from Feb 8, 2016

Conversation

@gdavison
Copy link
Contributor

gdavison commented Feb 6, 2016

Fixes #273 by creating Consul data directory

@johnbellone

This comment has been minimized.

Copy link
Contributor

johnbellone commented Feb 7, 2016

Did #274 solve this?

@gdavison

This comment has been minimized.

Copy link
Contributor Author

gdavison commented Feb 8, 2016

It's fixed.

One style comment: data_path_prefix is not used as a prefix, so it should be renamed to data_path, and the Windows-specific appending of the data path segment should be moved from the attribute file to the helpers.rb file. (Or just merge in this PR :) )

Also, I have a bunch of integration tests in this PR that would be helpful

Graham Davison added 2 commits Feb 6, 2016
@gdavison gdavison force-pushed the paybyphone:windows_data_path branch from 3b4e3f1 to 4b571f1 Feb 8, 2016
johnbellone added a commit that referenced this pull request Feb 8, 2016
Windows data path
@johnbellone johnbellone merged commit a9c2139 into sous-chefs:master Feb 8, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.