Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Windows installation issue #300

Merged
merged 1 commit into from
Mar 19, 2016
Merged

Fixed Windows installation issue #300

merged 1 commit into from
Mar 19, 2016

Conversation

Ginja
Copy link
Contributor

@Ginja Ginja commented Mar 19, 2016

The new binary installation provider was set to extract to '/opt/consul' regardless of platform. I incorporated helper methods to set a proper path for Windows clients.

johnbellone/rubyzip-cookbook#2 should also be merged as well. Without it, Chef clients < 12.5 will be unable to use this cookbook.

The new binary installation provider was set to extract to
'/opt/consul' regardless of platform. Incorporated helper methods
to set a proper path for Windows clients.
@shortdudey123
Copy link
Contributor

saw this issue earlier when running spec tests

Failure/Error:
  it { expect(chef_run).to install_nssm('consul').with(
    program: 'C:\Program Files\consul\consul.exe',
    args: 'agent -config-file="""C:\Program Files\consul\consul.json""" -config-dir="""C:\Program Files\consul\conf.d"""'
  )}

  expected "nssm[consul]" to have parameters:

    program "C:\\Program Files\\consul\\consul.exe", was "/opt/consul/0.6.4/consul.exe"
# ./test/spec/libraries/consul_service_windows_spec.rb:25:in `block (3 levels) in <top (required)>'

johnbellone added a commit that referenced this pull request Mar 19, 2016
@johnbellone johnbellone merged commit 9d3ecf5 into sous-chefs:master Mar 19, 2016
@knightorc knightorc deleted the fix-windows-install branch June 6, 2018 23:05
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants