Use config user/group for consul_definition instead of hard coded string

[rollbrettler]

Does anything speak against using the node['consul']['config']['group'] and node['consul']['config']['user'] value for the default consul_definition attributes?

[johnbellone]

Did you try setting node['consul']['service_user'] and node['consul']['service_group']? I don't really see why you would need to do this with those node attributes.

[codecov-io]

Current coverage is 57.77% (diff: 100%)

No coverage report found for master at 2a49cac.

Powered by Codecov. Last update 2a49cac...56e77ed

[rollbrettler]

I changed it to node['consul']['service_user'] and node['consul']['service_group'] but maybe I didn’t fully get your suggestion yet.

[rollbrettler]

@johnbellone #372 is basically what I ran into as well and what I tried to fix with this PR

[legal90]

It looks good to me. @johnbellone don't you mind to get it merged?
This PR should actually fix #372.

[mishak87]

Watch and service resources are still using hardcoded strings 'consul'.

https://github.com/johnbellone/consul-cookbook/blob/cd562a7/libraries/consul_watch.rb#L22-L28
https://github.com/johnbellone/consul-cookbook/blob/cd562a7/libraries/consul_service.rb#L24-L31

[legal90]

@mishak87 Thanks! Now it should be fixed by #445