Filter out bootstrap and bootstrap_expect parameters in client configs #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 71.92% (diff: 100%)
|
This reverts commit da50fb5.
|
Blocked by failing RSpec tests on master |
legal90
approved these changes
Nov 18, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out some server-specific parameters from client config files. Consul 0.7 refuses to start when, for instance,
bootstrap_expectis present.When we set up our development environments, we set the parameter on the whole Chef environment, as the number of Consul servers seems to fit as a property of the environment. So when I tried updating one of the dev environments today, each client machine failed.
I haven't tested which other parameters will cause failure, if any