Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup attributes of consul_config resource #400

Merged
merged 2 commits into from
Jan 18, 2017

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Jan 17, 2017

Closes #367

  1. Remove invalid attributes from consul_config resource:
  • dev_mode is not supported.
  • raft_multiplier should be nested into performance hash,
  • udp_answer_limit should be nested into dns_config hash,
  • recursor_timeout should be nested into dns_config hash,
  • disable_compression should be nested into dns_config hash.
  1. Unwrap the list of supported consul config options to multiple lines. Now It should be way easier to read and modify this list.

"dev_mode" is not supported.
"raft_multiplier" should be nested into "performance" hash.
These should be nested into "dns_config" hash:
- "udp_answer_limit"
- "recursor_timeout"
- "disable_compression"
It should be way easier to read and modify such list.
@legal90 legal90 changed the title Config cleanup Cleanup attributes of consul_config resource Jan 17, 2017
@codecov-io
Copy link

Current coverage is 72.23% (diff: 100%)

No coverage report found for master at b2fbd5f.

Powered by Codecov. Last update b2fbd5f...47adb85

@legal90 legal90 merged commit 36c1f8a into sous-chefs:master Jan 18, 2017
@legal90 legal90 deleted the config-cleanup branch January 18, 2017 12:51
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev_mode attribute causes error in startup
2 participants