Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nssm cookbook 3.0 #422

Merged
merged 1 commit into from
Apr 23, 2017
Merged

Conversation

Annih
Copy link
Contributor

@Annih Annih commented Apr 4, 2017

Nssm cookbook version 3.0 has been release with a breaking change.
The 'params' property has been renamed in 'parameters' for Chef 13 compat.

This code use 'parameters' if the resource expose this property and 'params'
otherwise.

Cc: @aboten

@codecov-io
Copy link

codecov-io commented Apr 10, 2017

Codecov Report

Merging #422 into master will decrease coverage by 8.35%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   70.89%   62.53%   -8.36%     
==========================================
  Files           7        7              
  Lines         347      347              
==========================================
- Hits          246      217      -29     
- Misses        101      130      +29
Impacted Files Coverage Δ
libraries/consul_service_windows.rb 23.21% <0%> (-0.43%) ⬇️
libraries/consul_definition.rb 44.44% <0%> (-47.23%) ⬇️
libraries/consul_execute.rb 55% <0%> (-45%) ⬇️
libraries/helpers.rb 48.64% <0%> (-5.41%) ⬇️
libraries/consul_config.rb 97.5% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6689d41...cb31444. Read the comment docs.

@legal90 legal90 modified the milestone: v3.0.0 Apr 11, 2017
Nssm cookbook version 3.0 has been release with a breaking change.
The 'params' property has been renamed in 'parameters' for Chef 13 compat.

This code use 'parameters' if the resource expose this property and 'params'
otherwise.
@legal90
Copy link
Contributor

legal90 commented Apr 23, 2017

@Annih Thank you for the contribution!

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants