Calling /etc/init.d/consul restart sometimes ends up with a stopped … #427
Conversation
…consul process. The reason was that it would sometimes start consul before it was completely stopped. This can be easily reproduced runnning: watch -n 0.5 -e '/etc/init.d/consul restart; sleep 0.1; /etc/init.d/consul status' Adding the --retry parameter lets start-stop-daemon wait until the consul process is actually stopped.
MichaelKueller
changed the title
|
The underlying issue has the potential to take down 20 percent of all consul agents when appliying a config change accross an entire environment. When hundreds of servers are involved easily dozens of them will be stopped instead of restarted. Which is why I believe this fix is quite important. |
libraries/consul_config.rb
Outdated
| @@ -27,6 +27,9 @@ class ConsulConfig < Chef::Resource | |||
| # @!attribute config_dir | |||
| # @return [String] | |||
| attribute(:config_dir, kind_of: String, default: lazy { node['consul']['service']['config_dir'] }) | |||
| # @!attribute config_dir_mode | |||
| # @return [String] | |||
| attribute(:config_dir_mode, kind_of: String, default: '0755') | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=========================================
Coverage ? 59.49%
=========================================
Files ? 7
Lines ? 358
Branches ? 0
=========================================
Hits ? 213
Misses ? 145
Partials ? 0
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
…consul process. The reason is that the init script sometimes starts consul before it was completely stopped. During a cookbook upgrade from version 2.1.3 to 2.2.0 this took down the consul agent on a number of our servers.
This can be easily reproduced runnning:
watch -n 0.5 -e '/etc/init.d/consul restart; sleep 0.1; /etc/init.d/consul status'
Adding the --retry parameter lets start-stop-daemon wait until the consul process is actually stopped.