Remove default attributes ['config']['owner'] and ['config']['group'] #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes are redundant in the default.rb attribute file since they cause a confusion about what are default values of `owner` and `group` params of `counsul_config` resource. Due to Poise inversion options, the node's attribute will always have a precedence. They are designed to be used by cookbook end-users in their wrapper cookbooks. We already have default values defined in the resource itself, so we can remove default attributes without any effect.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes are redundant in the default.rb attribute file because they cause
a confusion about how the default values of
consul_config'sownerandgroupparams are actually determined.Due to Poise inversion options, the node's attribute will always have a precedence.
They are designed to be used by cookbook end-users in their wrapper cookbooks.
We already have default values defined in the resource itself:
https://github.com/johnbellone/consul-cookbook/blob/eebc1299cefb6d766218904ea372566cc84bf373/libraries/consul_config.rb#L21-L26
Default values of
['service_owner']and['service_group']are "consul" too, so we canremove
['config']['owner']and['config']['group']without any effect.Fixes #405