add upstart init

[wilreichert]

Native upstart service for Ubuntu, it behaves identically to the sysvinit script. Anyone upgrading will get blessed with 2 init files which might cause a bit of confusion.

[coveralls]

Coverage remained the same when pulling ca34cf9 on wilreichert:upstart into 39940d0 on johnbellone:master.

[coveralls]

Coverage remained the same when pulling f9a5d6d on wilreichert:upstart into 39940d0 on johnbellone:master.

[lyrixx]

Hi.

I think it's a good idea to add upstart support.

But I don't like the implementation, because the restart command really restart the process.

I think it's better to check everywhere in the code where we call restart or reload and replace it with something custom to leverage consul's hot reload

[johnbellone]

The init script runs kill -INT and then just runs a normal start on the daemon. We should be able to do the same using upstart.

[wilreichert]

it look like upstart sends the appropriate SIGHUP for the reload
http://upstart.ubuntu.com/cookbook/#reload-signal

The restart is a SIGTERM followed by a start & that can be reconfigured as well.
http://upstart.ubuntu.com/cookbook/#kill-signal

[coveralls]

Coverage remained the same when pulling c666027 on wilreichert:upstart into 0d96fc4 on johnbellone:master.

[lyrixx]

This PR is not BC. More often, it's a big BC break, because on existing node, I had consul with init.d and now, I have both init and upstart. And so chef failed:

 * service[consul] action restart[2014-12-30T14:04:00+00:00] INFO: Processing service[consul] action restart (consul::_service line 211)


    ================================================================================
    Error executing action `restart` on resource 'service[consul]'
    ================================================================================

    Chef::Exceptions::Exec
    ----------------------
    /sbin/start consul returned 1, expected 0

    Resource Declaration:
    ---------------------
    # In /var/chef/cache/cookbooks/consul/recipes/_service.rb

    211:   service 'consul' do
    212:     provider Chef::Provider::Service::Upstart if platform?("ubuntu")
    213:     supports status: true, restart: true, reload: true
    214:     action [:enable, :start]
    215:     subscribes :restart, "file[#{consul_config_filename}", :delayed
    216:   end
    217: when 'runit'

[lyrixx]

Hi, Sorry to "spam" this thread, but what id the right procedure to migrate ?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.