WIP: LISA conference hacking #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ | |||
| path node['consul']['install_dir'] | |||
| version node['consul']['version'] | |||
| checksum install_checksum | |||
| url ::URI.join(node['consul']['base_url'], "#{install_version}.zip").to_s | |||
| url node['consul']['base_url'] % { version: install_version } | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@johnbellone this looks awesome, merge it when you're ready! |
This fixes #41 as well as adds support for Ubuntu 10.04 and EL7.
This seems to have slipped through a little bit.
This is only suggested if you want to use chef-provisioning to start a cluster using the recipe in the root of the directory.
johnbellone
added a commit
that referenced
this pull request
Dec 11, 2014
WIP: LISA conference hacking
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reset Review when you get a few cycles. This isn't finished yet. Internet is slow here so I can't yet confirm or deny that the tests are passing.