Add some additional options to the service_config hash. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| license 'Apache v2.0' | |||
| description 'Installs/Configures consul' | |||
| long_description 'Installs/Configures consul' | |||
| version '0.5.1' | |||
| version '0.5.2' | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
You are not able to set the extra_params attribute as a hash? |
|
I did see that - but the pattern looked like I should be able to just set attributes - so I kept using that pattern. I can use extra_params - thought this was better - although a bit more maintenance. |
|
Can you revert the commit for the bump? |
|
Done and pushed! |
johnbellone
added a commit
that referenced
this pull request
Dec 11, 2014
Add some additional options to the service_config hash.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows those options to be configured through node attributes. Before, they didn't seem to work at all.
Would you consider merging this?