Add Fedora support #114
Merged
Add Fedora support #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bmhughes could you re-base this pr? I have just updated all the testing setup for this cookbook so things should be easier now 👍
Thanks |
|
Sure no problem, all done. |
damacus
previously requested changes
May 16, 2019
|
Can you add a changelog entry please? Danger will stop complaining about it and we wont forget to add it to the changelog later on :) |
|
Also done, the only reason I didn't as I wasn't 100% sure whether to add to it or not due to the do's and don't's here. |
xorima
previously approved these changes
May 16, 2019
Add attributes case match for Fedora and skips creating the `init_config` as it is no longer instead init options are added to a customised systemd unit file.
|
Rebased onto the current master. |
damacus
approved these changes
Aug 11, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Fedora.
Add attribute case match for Fedora and skips creating the
init_configasit is no longer used.
Add Fedora to Kitchen.
Issues Resolved
Contribution Check List