Error executing action login on resource docker_registry

[psviderski]

I use the latest version of chef-docker cookbook from the master branch. When I try to login to a private repository the following error is occurred:

================================================================================
Error executing action `login` on resource 'docker_registry[https://registry.xxx.com]'
================================================================================


Errno::ENOENT
-------------
No such file or directory - /root/.dockercfg


Cookbook Trace:
---------------
/tmp/vagrant-chef-1/chef-solo-2/cookbooks/docker/libraries/helpers.rb:59:in `read'
/tmp/vagrant-chef-1/chef-solo-2/cookbooks/docker/libraries/helpers.rb:59:in `dockercfg_parse'
/tmp/vagrant-chef-1/chef-solo-2/cookbooks/docker/providers/registry.rb:6:in `load_current_resource'


Resource Declaration:
---------------------
# In /tmp/vagrant-chef-1/chef-solo-1/cookbooks/test/recipes/default.rb

  1: docker_registry 'https://registry.xxx.com' do
  2:   username 'xxx'
  3:   password 'yyy'
  4: end
  5:

Do I have to manually create the missing /root/.dockercfg file?
Btw, when I create it with the content:

{}

it still doesn't solve the problem.
It seems that logged_in? always returns true even if we are not logged in. Because of this, the login function isn't called.

[bflad]

Added two simple fixes, which you can either use from master or 0.34.0 which I'll be releasing momentarily:

• rescue when .dockercfg doesn't exist and return nil
• Explicitly set TrueClass or FalseClass in logged_in? method

If you still have trouble, please let me know. Thanks for the detailed report.

[psviderski]

It seems you didn't fix the issue with logged_in? method. Why are you checking the .server attribute in order to determine whether we are logged in?

attribute :server, :name_attribute => true

.server is a name attribute, so it seems to be assigned on a fresh @current_resource.
I would rather check a .username or a .password attribute.

[bflad]

Hmmm good point... I just figured it wouldn't exist in @current_resource unless this ran: https://github.com/bflad/chef-docker/blob/master/providers/registry.rb#L9

I'll move it to checking username instead.