Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef 18 #1246

Merged
merged 9 commits into from May 29, 2023
Merged

Chef 18 #1246

merged 9 commits into from May 29, 2023

Conversation

b-dean
Copy link
Contributor

@b-dean b-dean commented May 23, 2023

Description

Change remaining library class-based resources to into custom resources. Also fix the various docker_installation and docker_service resources to work in unified mode (which is on by default in Chef 18).

Issues Resolved

#1222
This also includes the changes in #1245

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
@b-dean b-dean requested a review from a team as a code owner May 23, 2023 18:04
@b-dean b-dean marked this pull request as draft May 23, 2023 18:06
…ef workstation version

Signed-off-by: Ben Dean <ben.dean@finvi.com>
@b-dean b-dean force-pushed the chef-18 branch 3 times, most recently from a9ebee5 to 22b972d Compare May 23, 2023 19:30
@b-dean b-dean marked this pull request as ready for review May 23, 2023 19:32
Signed-off-by: Ben Dean <ben.dean@finvi.com>
…it times out

Signed-off-by: Ben Dean <ben.dean@finvi.com>
not exactly a fix for sous-chefs#1222

Signed-off-by: Ben Dean <ben.dean@finvi.com>
The following resources are now custom resources:
- `docker_installation`
- `docker_installation_package`
- `docker_installation_script`
- `docker_installation_tarball`
- `docker_service`
- `docker_service_base`
- `docker_service_manager`
- `docker_service_manager_execute`
- `docker_service_manager_systemd`

This fixes sous-chefs#1222 so the docker cookbook will work with Chef 18

Signed-off-by: Ben Dean <ben.dean@finvi.com>
@b-dean b-dean mentioned this pull request May 23, 2023
3 tasks
@edgarasg
Copy link

Can this be merged?

@bmhughes bmhughes added the Release: Major Release to Chef Supermarket as a major change when merged label May 29, 2023
@bmhughes bmhughes merged commit 088849d into sous-chefs:main May 29, 2023
54 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 11.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Major Release to Chef Supermarket as a major change when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants