Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value_for_platform package attributes for ubuntu 14.04. #171

Merged

Conversation

jperville
Copy link
Contributor

#168 allowed to override the name of the docker package to install, with default of lxc-docker for all ubuntu and debian platform. However, the refactoring done in c4f1570 broke it for me, because I run ubuntu 14.04 which is not listed in the value_for_platform cases.

This PR fixes it for ubuntu 14.04, but does not handle the upcoming 14.10 and later releases (which are likely to be affected too).

@bflad
Copy link
Contributor

bflad commented Jun 26, 2014

I'm curious what others think: whether we should default to lxc-docker from the PPA or use the distro package on Ubuntu 14.04? Normally I'd opt for distro default to leave out the "custom" bits, but the lag between releases is pretty far at this point (0.9.1! I only see 0.11.1 in 14.04 testing distro repo too). If I get a community +1 and no -1's, then I'll merge this in or we can discuss further.

@jperville
Copy link
Contributor Author

I vote for using the ppa by default, since docker is still not production ready (even if 1.0.0 was released recently). To only talk about security, the shocker exploit was only patched on 0.12.0, making ppa package users safe from it but not distro package users.

@djdefi
Copy link

djdefi commented Jun 26, 2014

For now I will +1 the ppa default, due to the current security landscape and the pace of official distro package updates.

Once the distro's get better at keeping up their official packages, I feel like the distro package is what should be default but it doesn't seem like we are quite there yet.

@bflad
Copy link
Contributor

bflad commented Jun 26, 2014

Good enough for me. Let's roll with it.

bflad added a commit that referenced this pull request Jun 26, 2014
Fix value_for_platform package attributes for ubuntu 14.04.
@bflad bflad merged commit 19f9d46 into sous-chefs:master Jun 26, 2014
@jperville jperville deleted the ubuntu-trusty-default-attributes branch June 26, 2014 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants