Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont include lxc cookbook and aufs recipe on ubuntu 13.10 and up #34

Merged
merged 2 commits into from
Jan 2, 2014

Conversation

bkw
Copy link
Contributor

@bkw bkw commented Dec 19, 2013

this essentially adds upport for ubuntu saucy (13.10) and hopefully following versions.
See discussion in #32.

@jayofdoom
Copy link
Contributor

AFAICT, the LXC cookbook shouldn't even be required for 12.04+ as well. Is there any reason we can't make this an attribute so I can completely disable LXC/AUFS on any supported Ubuntu?

@bkw
Copy link
Contributor Author

bkw commented Dec 19, 2013

We still need the aufs recipe for 12.04 with the old kernel though.

Fix coming.

@jayofdoom
Copy link
Contributor

I'll test your branch in my local docker dev VM. Thanks!

@jayofdoom
Copy link
Contributor

LGTM. Docker still installs and runs properly in my Ubuntu Precise VM.

@bflad
Copy link
Contributor

bflad commented Dec 30, 2013

This change will break fresh installs with install_type = binary, which is why LXC dependency was originally included in the cookbook (before the docker packages came around).

2013/12/30 08:16:28 WARNING: You are running linux kernel version 3.5.0-23-generic, which might be unstable running docker. Please upgrade your kernel to 3.8.0.
[/var/lib/docker|64d07c41] +job initapi()
[/var/lib/docker|64d07c41.initapi()] Creating server
exec: "lxc-start": executable file not found in $PATH[/var/lib/docker|64d07c41] -job initapi() = ERR (1)
2013/12/30 08:16:28 initapi: exec: "lxc-start": executable file not found in $PATH

We can handle this various ways:

  • leave include_recipe 'docker::lxc' in docker::default and only install lxc packages in docker::lxc
  • re-add with conditional include_recipe 'docker::lxc' if node['docker']['install_type'] == 'binary'
  • maybe something more elegant?

@jayofdoom
Copy link
Contributor

I'd be +1 to option 2 -- where we only require docker:lxc if you're using 'binary' install type.

@jayofdoom
Copy link
Contributor

Based off this branch, I implemented option 2 here: #37

Thanks!

@bflad bflad merged commit 0f4f154 into sous-chefs:master Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants