Broken attempted aws plugin installation by default

[jeremyolliver]

I'm not including the aws recipe, just the default and plugins recipes. The aws plugin is attempted to install by default, and fails installation (possibly due to github no longer serving their downloads service?). The install plugin block fires every chef run because this plugin is still not installed (though the chef run completes cleanly), and also triggers the notification to restart elasticsearch (restarting elasticsearch every chef run is the main issue I see with this).

I'd be fine if either, the plugin install block didn't trigger a restart if the installation failed, or the default settings actually successfully completed the aws plugin install that they attempt.

I believe the cause of this plugin being installed by default is that the attributes/aws.rb sets a version for it though chef will parse and evaluate all attributes files even if the elasticsearch::aws recipe isn't included. (And of course presence of the key in the plugins attributes triggers the install)

[karmi]

I believe this could be solved by d00113f in #75, thanks for the report!

I believe the cause of this plugin being installed by default is that the attributes/aws.rb sets a version for it though

Agreed!, this sounds like the cause for it.

[jeremyolliver]

I tried out the branch from that pull request, but that didn't fix it. This change jeremyolliver@a5b0368 (ontop of the branch in #75) does get the aws plugin installing correctly when using the elasticsearch::plugins recipe without elasticsearch::aws by specifying the plugin as "elasticsearch/elasticsearch-cloud-aws" not just aws or elasticsearch-cloud-aws.

This is definitely an improvement, in that elasticsearch isn't restarted every chef run, but I think ideal would be that the aws plugin isn't installed by default, unless explicitly included. This could be accomplished by either moving the version in attributes/aws.rb out of the hash that the plugins recipe checks to install from (e.g. default.elasticsearch['aws']['plugin_version'] = '1.11.0'), or by moving the setting of that attribute to inside the recipe itself.

[jeremyolliver]

I'll wait until 75 is merged in before submitting this change. In the mean time I may see about making that change that I mentioned

[karmi]

This is definitely an improvement, in that elasticsearch isn't restarted every chef run, but I think ideal would be that the aws plugin isn't installed by default, unless explicitly included.

Absolutely right. The plugin shouldn't be installed when you don't include the recipe, and I think your suggestions are spot on. I'll try to process #75 as soon as possible.

[karmi]

Hi, I think the attached commit solves the issue, thanks for the report!

[jeremyolliver]

I believe so, thanks