Fix a bunch of the AWS recipe issue #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 2, 2013 15:10
…discovery.ec2.group, upgrade plugin
… that recipe (like in dev)
… the plugin recipe will fail as it tries to install it causing elasitcsearch to restart on every chef run.
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
Fixing issue with AWS plugin, attribute for security group should be discovery.ec2.group
karmi
added a commit
that referenced
this pull request
Mar 6, 2013
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
* Force installation of packages required for the Fog gem before the Chef run * Use `run_action` for the Fog gem
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
karmi
added a commit
that referenced
this pull request
Mar 6, 2013
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
… using that recipe (like in dev)
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
The "elasticsearch-cloud-aws" plugin can't be named just "aws" in the plugin attributes, as the plugin recipe will tries to install it, and fail, causing Elasticsearch to restart on every Chef run.
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
The "elasticsearch-cloud-aws" plugin can't be named just "aws" in the plugin attributes, as the plugin recipe will tries to install it, and fail, causing Elasticsearch to restart on every Chef run.
karmi
added a commit
that referenced
this pull request
Mar 6, 2013
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
* Force installation of packages required for the Fog gem before the Chef run * Use `run_action` for the Fog gem
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
karmi
added a commit
that referenced
this pull request
Mar 6, 2013
karmi
pushed a commit
that referenced
this pull request
Mar 6, 2013
… using that recipe (like in dev)
|
Hi, thanks for all the patches! Finally found time to review and merge it. I've retouched it a bit and also reverted two commits:
Verifying with Chef Server now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You dont need to install the dep for fog using bootstrap. You can use run_action to have the dependences be installed at compile time before chef_gem is ran. The build-essential cookbook works this way and is needed to have compile time flag set to true.
The security group stuff for AWS was incorrect according to the plugin docs: https://github.com/elasticsearch/elasticsearch-cloud-aws see EC2 Discovery. I also rev'ed the version since I was editing the file.
I was getting a discovery_tags nil error since I was not setting that and while it rescues the nil value it still try to enumerate over it. Set a unless block to protect this.