Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#100 Don't seem to be able to change the version #165

Closed
wants to merge 2 commits into from

Conversation

weiner
Copy link

@weiner weiner commented Nov 26, 2013

This change allows to overwrite the elasticsearch version in a role and fixes the issues that the new version didn't got downloaded.

role.rb

....

override_attributes({
:elasticsearch => {
:version => "0.90.7"
}
})

@karmi
Copy link
Contributor

karmi commented Dec 19, 2013

This is one approach, with one rather big downside, if I'm not mistaken -- users can't set node.elasticsearch.download_url to some private/special/etc URL, possibly within their organization, etc.

@lyrixx
Copy link

lyrixx commented Sep 6, 2014

Ping.

I have the same issue. in my cookbook, I added in attributes/customize.rb the following lines:

normal[:elasticsearch][:version] = '1.1.0'

And this create:

greg@elasticsearch-0:~$ ll /usr/local/
total 48
drwxr-xr-x 12 root          root          4096 Sep  5 23:54 ./
drwxr-xr-x 10 root          root          4096 Jun  7 10:49 ../
drwxr-xr-x  2 root          root          4096 Sep  5 23:54 bin/
lrwxrwxrwx  1 root          root            30 Sep  5 23:54 elasticsearch -> /usr/local/elasticsearch-1.1.0/
drwxr-xr-x  6 elasticsearch elasticsearch 4096 Sep  5 23:54 elasticsearch-1.1.0/

but

greg@elasticsearch-0:~$ ll /usr/local/elasticsearch-1.1.0/lib/
total 18392
drwxr-xr-x 3 elasticsearch elasticsearch     4096 Sep  5 23:54 ./
drwxr-xr-x 6 elasticsearch elasticsearch     4096 Sep  5 23:54 ../
-rw-rw-r-- 1 elasticsearch elasticsearch 10952807 Feb 25  2014 elasticsearch-0.90.12.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   865400 Dec 18  2013 jna-3.3.0.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   770462 Dec 18  2013 jts-1.12.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   489884 Dec 18  2013 log4j-1.2.17.jar
-rw-rw-r-- 1 elasticsearch elasticsearch  1589251 Jan 28  2014 lucene-analyzers-common-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   343074 Jan 28  2014 lucene-codecs-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch  2348962 Jan 28  2014 lucene-core-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   107622 Jan 28  2014 lucene-grouping-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   128037 Jan 28  2014 lucene-highlighter-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch    64417 Jan 28  2014 lucene-join-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch    35839 Jan 28  2014 lucene-memory-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch    95780 Jan 28  2014 lucene-misc-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   210979 Jan 28  2014 lucene-queries-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   383927 Jan 28  2014 lucene-queryparser-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch    45695 Jan 28  2014 lucene-sandbox-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch    93409 Jan 28  2014 lucene-spatial-4.6.1.jar
-rw-rw-r-- 1 elasticsearch elasticsearch   184919 Jan 28  2014 lucene-suggest-4.6.1.jar
drwxrwxr-x 2 elasticsearch elasticsearch     4096 Feb 12  2014 sigar/
-rw-rw-r-- 1 elasticsearch elasticsearch    69290 Dec 18  2013 spatial4j-0.3.jar

as you can see, the version inside the 1.1 folder is elasticsearch-0.90.12.jar.

How can I fix that ?

@karmi
Copy link
Contributor

karmi commented Sep 6, 2014

I'm torn between this approach and what I added in #180 (comment). See the linked article: https://coderanger.net/derived-attributes/

Moreover, I'm really wary of any invasive change to the cookbook, I don't have the bandwidth to properly test it etc.

@martinb3 martinb3 closed this Jul 2, 2015
@martinb3
Copy link
Contributor

martinb3 commented Jul 3, 2015

Hi there -- we've promoted a new, fully re-written branch to master on this cookbook. We've discovered Github actually automatically closes all PRs when the branch they're made onto is moved. Please consider re-opening/resubmitting if your PR still applies to the re-written cookbook. I apologize for the automatic close that Github made on this PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants