remove metadata locking #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Would be nice to see this merged. |
|
Hmm, I was just bit by the strict version dependencies on minor versions. Maybe a good compromise could be to set minimum version dependencies? |
|
Thank you for the contribution! Will be catching up on PRs and fixes needed for this repo in the next day or so, and then I'll be doing a release. Cheers! |
|
Had to cherry pick and rebase since this wasn't against latest master, and I didn't want to rebase master to apply it. Merged in 6778dda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
The metadata locking is way behind and should be left to the user in my opinion.
The poise dependency breaks cookbooks like consul for example.
Thanks for looking into it.