Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file scope #151

Merged
merged 5 commits into from May 18, 2023
Merged

Config file scope #151

merged 5 commits into from May 18, 2023

Conversation

jmauro
Copy link
Contributor

@jmauro jmauro commented May 24, 2022

Description

I would like to add the scope file as specified in the git-config documentation

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@jmauro jmauro requested a review from a team as a code owner May 24, 2022 16:56
@ramereth ramereth added the Release: Minor Release to Chef Supermarket as a minor release when merged label Aug 7, 2022
@jmauro @ramereth
feat(config_file): Add the 'file' scope
9b9227a 
STATE:
In the 'git-config' documentation, there is the possibility to use the
'--file <config_file>' scope.

PROPOSED SOLUTION:
- Add the 'file' scope in the resource 'scope'
- Add the 'config_file' property

Signed-off-by: Jeremy MAURO <jeremy.mauro@gmail.com>
@jmauro @ramereth
test(config_file): Add test for the new 'file' scope feature
684d3b8 
Signed-off-by: Jeremy MAURO <jeremy.mauro@gmail.com>
@jmauro @ramereth
test(config_file): Add integration test for 'config_file'
c567b4f 
Signed-off-by: Jeremy MAURO <jeremy.mauro@gmail.com>
@jmauro @ramereth
doc(config_file): Update the changelog to add 'config_file' feature
faf1870 
Signed-off-by: Jeremy MAURO <jeremy.mauro@gmail.com>
@damacus
Copy link
Member

damacus commented May 18, 2023

Apologies for taking so long to notice this one. Looks like a solid, well tested PR.

@damacus damacus enabled auto-merge (squash) May 18, 2023 13:21
@damacus damacus merged commit dde143d into sous-chefs:main May 18, 2023
31 of 33 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 12.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damacus damacus damacus approved these changes

Assignees
No one assigned
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmauro @damacus @kitchen-porter @ramereth