Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include non provisioned nodes #79

Closed
obazoud opened this issue Jun 13, 2014 · 2 comments
Closed

Do not include non provisioned nodes #79

obazoud opened this issue Jun 13, 2014 · 2 comments
Assignees

Comments

@obazoud
Copy link
Contributor

obazoud commented Jun 13, 2014

Hi,

When a node is defined in a Chef server but not yet provisioned, ip address is not set.
The HAProxy configuration is wrong and prevents the service to start.

As you can see, there are no ip in this case:

backend servers-http
  server  :8080 weight 1 maxconn 100 check

So at lthis line https://github.com/hw-cookbooks/haproxy/blob/master/recipes/app_lb.rb#L28, pool_members without ipaddress should be excluded.

Thoughts ?
Olivier.

@slyness
Copy link

slyness commented Sep 9, 2014

Seems like a bug to me. We are working on some improvements to the lb resource along with how the log file is generated, and node discovery. I will use this as a validation check.

@rshade rshade self-assigned this Jan 26, 2017
@rshade rshade closed this as completed in 7c37930 Jan 26, 2017
rshade added a commit that referenced this issue Jan 26, 2017
closes #79, does not include host if ip is null.
@lock
Copy link

lock bot commented Jun 14, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants