New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Oracle JDK 1.8.0 (closes #147) #148

Merged
merged 1 commit into from Mar 19, 2014

Conversation

Projects
None yet
2 participants
@davidmc24
Contributor

davidmc24 commented Mar 19, 2014

No description provided.

# pad a single digit number with a zero
if update_num.length < 2
update_num = "0" + update_num
end
package_name = file_name.scan(/[a-z]+/)[0]
app_dir_name = "#{package_name}1.#{major_num}.0_#{update_num}"
if update_num == "00"

This comment has been minimized.

@carmstrong

carmstrong Mar 19, 2014

Contributor

Will it ever be "00"? It looks like you're setting it to "0" as a default in line 34.

@davidmc24

This comment has been minimized.

Contributor

davidmc24 commented Mar 19, 2014

There's a line in between that pads any 1 digit update nums to 2 digits.

@carmstrong

This comment has been minimized.

Contributor

carmstrong commented Mar 19, 2014

Gotcha - sorry, I reviewed this while I was still waking up.

carmstrong added a commit that referenced this pull request Mar 19, 2014

Merge pull request #148 from davidmc24/feature/java8
Add support for Oracle JDK 1.8.0 (closes #147)

@carmstrong carmstrong merged commit f03896a into sous-chefs:master Mar 19, 2014

@davidmc24 davidmc24 deleted the davidmc24:feature/java8 branch Apr 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment