Moving configuration dependent on version/install_flavor to a recipe #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that the user can override node['java']['jdk_version'] and node['java']['install_flavor'] before they are used to compute other attributes, such as openjdk_packages. This is necessary to make it possible to override version/install_flavor in a data bag using the bag_config cookbook.
|
This was taken care of in PR #95. Feel free to open a new PR if you want to make further changes! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that the user can override node['java']['jdk_version'] and
node['java']['install_flavor'] before they are used to compute other
attributes, such as openjdk_packages. This is necessary to make it
possible to override version/install_flavor in a data bag using the
bag_config cookbook.