Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ulimit number by default #79

Closed
spuder opened this issue Mar 19, 2015 · 4 comments
Closed

Set ulimit number by default #79

spuder opened this issue Mar 19, 2015 · 4 comments

Comments

@spuder
Copy link
Contributor

spuder commented Mar 19, 2015

I think the default value for the ulimit should be set by default.

After days of crashes, and various conversations in the IRC chanel, I discovered that kafka was exceeding the maximum number of open files.

Someone pointed out that this cookbook can set the ulimit right inside of the upstart file.

bmhatfield/chef-ulimit#38

Even users with simple configurations will run out of open files. Should the limit be set by default?

spuder added a commit to spuder/kafka-cookbook that referenced this issue Mar 19, 2015
Resolves issue sous-chefs#79

Users are almost guaranteed to run into problems if the ulimit file is set to nil. Sets a default value so that it is added to the upstart config.
@mthssdrbrg
Copy link
Contributor

My opinion is that the limit shouldn't be set by default. Personally I prefer when cookbooks makes as little decisions as possible on their own, and where things are as configurable as possible (to an extent when it just becomes cumbersome to use).

Furthermore, I believe that it's pretty difficult to set a reasonable default limit as it depends on what kind of infrastructure we're talking about (i.e. shared resources using something like Mesos or a system where Kafka is the only thing running). Why would 64k be better than 32k for example?

@spuder
Copy link
Contributor Author

spuder commented Apr 2, 2015

Agreed that the cookbook shouldn't set a system wide limit. But since this limit is only for the kafka user, the influence should be minimal.

Perhaps there is some middle ground? Not setting a default leads to a bad out of the box user experience because kafka will work for a short period and then crash. It took me a long time to figure out why the cookbook wasn't just working out of the box. Maybe a warning in the README would be appropriate?

@mthssdrbrg
Copy link
Contributor

A heads up section in the README would definitely be appropriate.

mthssdrbrg added a commit that referenced this issue Jul 3, 2015
As to avoid further issues about things that has already been brought
up and explained previously.

Closes #78, closes #79, and closes #80.
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants