Sensitive: Test on chef 12. Minor fix for the sensitive attribute #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damacus
reviewed
Jun 3, 2018
| @@ -11,6 +11,9 @@ def raise_not_found | |||
|
|
|||
| def sensitive_default | |||
| new_resource.sensitive = true unless property_is_set?(:sensitive) | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Ah good point, it's a sensible default.
Go with it!
…On Sun, 3 Jun 2018, 16:38 Mark Gibbons, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In libraries/helper.rb
<#111 (comment)>
:
> @@ -11,6 +11,9 @@ def raise_not_found
def sensitive_default
new_resource.sensitive = true unless property_is_set?(:sensitive)
Setting sensitive to true for chef 12 seemed like my best option. With
Chef 13 and up folks can specify the sensitive property and it works
correctly.
For chef 12 new_resource.sensitive defaults to false instead of nil. So I
can't tell if it has been set and property_is_set?(:sensitive) throws an
ArgumentError. The line resources used to always act like sensitive was
true before we used the internal file resource so I'm trying go back to
that behavior just for chef 12.
Isn't "val" in the code above is always going to be truthy?
thanks,
Mark
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#111 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACfUijK9q3WVrWhVHVudi4gpZNXL-nrks5t5AL7gaJpZM4UXc0_>
.
|
|
@damacus Could you hit the approval button on a review? |
damacus
approved these changes
Jun 6, 2018
MarkGibbons
added a commit
to MarkGibbons/line
that referenced
this pull request
Jul 19, 2018
…us-chefs#111) * Sensitive: Test on chef 12. Minor fix for the sensitive attribute * Undo the .travis.yml modifications
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test and run the cookbook on chef 12
Issues Resolved
#110
Contribution Check List
This change is