Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replication provider and server_id #118

Closed

Conversation

jwmarshall
Copy link

START SLAVE fails due to nil string when replication resource name is default.
Fix server_id key in replication config.

@jwmarshall
Copy link
Author

jwmarshall commented Sep 4, 2016

Meant to PR this on my own branch to continue testing, but fix is probably relevant to anyone who wants to use the replication provider.

@aberrios85
Copy link

Just hit this one. Can we get this pulled?

@jwmarshall
Copy link
Author

@aberrios85 you're welcome to use the master branch of my fork which has merged all three of the PR's I have pending with this cookbook.

@shoekstra
Copy link
Contributor

Hi!

I'm in process of sorting out some integration tests for this cookbook - once those are done we can rebase and try get this merged!

@shoekstra
Copy link
Contributor

Looks good! I've rebased this PR off master and it will be merged via #140 if all goes well.

shoekstra added a commit that referenced this pull request Mar 11, 2017
Fix replication provider and server_id (rebased #118)
@shoekstra
Copy link
Contributor

Merged in #140 - thanks!

@shoekstra shoekstra closed this Mar 11, 2017
jfwm2 pushed a commit to jfwm2/mariadb that referenced this pull request Apr 4, 2017
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants