Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scl installation #148

Closed
wants to merge 38 commits into from
Closed

Scl installation #148

wants to merge 38 commits into from

Conversation

dimsh99
Copy link
Contributor

@dimsh99 dimsh99 commented Mar 13, 2017

Recipe and attributes to install mariadb from Software Collections repository on centos6/7.

JCotton1123 and others added 30 commits November 11, 2016 18:00
Add missing code to my.cnf template to deploy mysqld_safe options
Add support for configuring skip-name-resolve
Add sensitive since foodcritic #233 is fixed.
- Correct Units Tests (Use ServerRunner instead of SoloRunner to test search)
- Correct ServerSpec tests
- Bump version to 1.0.1
* Switch bundler/gems to Chef DK as it already has all tools needed for testing
* Switch rubocop to cookstyle
* Add a .rubocop_todo.yml for cookbook warnings
* Add a rake task to test style and spec
* Deleted Gemfile

Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com>
open_files_limit should typically be a fixnum, not a string, so empty is not correct - swap to nil?
- Add new APT signing key (also fixes #107)
- Add Docker tests for Travis
- Add Supermarket version badge to README
- Change VirtualBox box names to use recent versions
- Change Travis badge in README to show master build status
- Remove Fedora tests, not something we'll test going forward
@dimsh99 dimsh99 closed this Mar 13, 2017
@shoekstra
Copy link
Contributor

This looks great! Please recreate PR when ready.

You should rebase off master and fix any conflicts before creating another PR. I have gone through all other open PRs and done this for them.

Look forward to seeing this being reopened 👍

@dimsh99 dimsh99 mentioned this pull request Mar 13, 2017
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants