Enable logging #150
Merged
Enable logging #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoekstra
reviewed
Mar 17, 2017
recipes/_audit_plugin.rb
Outdated
| @@ -14,20 +14,25 @@ | |||
| audit_plugin_options['server_audit_syslog_priority'] = \ | |||
| node['mariadb']['audit_plugin']['server_audit_syslog_priority'] | |||
|
|
|||
| audit_plugin_options['enable'] = '#server_audit_logging = ON' | |||
| audit_plugin_options['server_audit_logging'] = 'ON' | |||
|
|
|||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
shoekstra
reviewed
Mar 19, 2017
recipes/_audit_plugin.rb
Outdated
| @@ -44,6 +49,7 @@ | |||
| node['mariadb']['audit_plugin']['server_audit_syslog_facility'] + '\';' \ | |||
| 'SET GLOBAL server_audit_syslog_priority=\'' + \ | |||
| node['mariadb']['audit_plugin']['server_audit_syslog_priority'] + '\';"' \ | |||
| 'SET GLOBAL server_audit_logging=\'ON\';' \ | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
The tests need some fixing before this can be merged. Some |
|
Included in v1.3.0 release on supermarket. Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables logging by default in this recipe, not sure why it wasn't by default, I mean why bother configuring all this logging if you don't want to use it? Also adds the password and user to the mysql commands and marks the execute as sensitive.