Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct galera 10.2 #197

Merged
merged 1 commit into from
May 22, 2018
Merged

Correct galera 10.2 #197

merged 1 commit into from
May 22, 2018

Conversation

sinfomicien
Copy link
Contributor

damacus
damacus requested changes May 15, 2018
View reviewed changes
metadata.rb Outdated
@@ -7,7 +7,7 @@
source_url 'https://github.com/sous-chefs/mariadb' if respond_to?(:source_url)
issues_url 'https://github.com/sous-chefs/mariadb/issues' if respond_to?(:issues_url)
chef_version '>= 12.6' if respond_to?(:chef_version)
version '1.5.3'
version '1.5.4'

This comment was marked as outdated.

Sign in to view

recipes/_debian_galera.rb Outdated
@@ -35,7 +35,12 @@
end
end

template '/var/cache/local/preseeding/mariadb-galera-server.seed' do
preseed_file = '/var/cache/local/preseeding/mariadb-galera-server.seed'

This comment was marked as outdated.

Sign in to view

@sinfomicien sinfomicien force-pushed the correct-galera-10.2 branch 2 times, most recently from bf3422e to 794bdec Compare May 22, 2018 12:25
@sinfomicien
Make the galera recipe ready for MariaDB 10.2
392a548 
- Correct preseed filename for MariaDB Galera > 10.2
- Correct templates so that the root passord is initialy changed
- Add mariabackup SST method (sous-chefs#192)
- Add tests for debian-9 and galera with mariabackup
@sinfomicien
Copy link
Contributor Author

@damacus , i changed my code according to your review. Then rebase and squash everything. Does it seem ok for you now ?

@damacus damacus merged commit 27ff992 into sous-chefs:master May 22, 2018
@damacus
Copy link
Member

damacus commented May 22, 2018

Thanks!
Nice one.

@lock
Copy link

lock bot commented Oct 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damacus damacus damacus approved these changes

@shoekstra shoekstra Awaiting requested review from shoekstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sinfomicien @damacus